| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 15 Mar 2012 08:56:46 +0000 From: James Bottomley <James.Bottomley@...senPartnership.com> To: "Nanjappa, Sathisha (MCXS, Cupertino)" <sathisha.nanjappa@...com> Cc: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] mpt2sas: Corrected the constant in comparison to a hexadecimal. On Wed, 2012-03-14 at 23:36 +0000, Nanjappa, Sathisha (MCXS, Cupertino) wrote: > > > > On Tue, 2012-03-13 at 11:59 -0700, Sathisha Nanjappa wrote: > > > Bugzilla 42142 - mpt2sas: Number specified in wrong base > > > https://bugzilla.kernel.org/show_bug.cgi?id=42142 > > > > From: James Bottomley > > Sent: Wednesday, March 14, 2012 1:34 AM > > Do you have a better description ... like what is the user > > visible effect of correcting the constant? > > > > Does this look better: > > "This fix ensures that the IOP_LOGINFO_CODE_TASK_TERMINATED > messages do not clutter the sas_log_info messages." Much better, thanks. The whole point of a commit message is to explain what you're doing and why you're doing it. Just translating C to english isn't useful because everyone who looks a kernel patches can read C. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists