linux-kernel - Re: [V3 PATCH 1/2] drivers-gpu-drm-allow-to-load-edid-firmware.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Mar 2012 11:45:23 +0100
From:	Carsten Emde <C.Emde@...dl.org>
To:	Bastien ROUCARIES <roucaries.bastien@...il.com>
CC:	David Airlie <airlied@...ux.ie>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Valdis Kletnieks <Valdis.Kletnieks@...edu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Keith Packard <keithp@...thp.com>,
	Paul Menzel <paulepanter@...rs.sourceforge.net>,
	DRI <dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [V3 PATCH 1/2] drivers-gpu-drm-allow-to-load-edid-firmware.patch

Bastien,

>> Broken monitors and/or broken graphic boards may send erroneous or no
>> EDID data. This also applies to broken KVM devices that are unable to
>> correctly forward the EDID data of the connected monitor but invent
>> their own fantasy data.
>>
>> This patch allows to specify an EDID data set to be used instead of
>> probing the monitor for it. It contains built-in data sets of frequently
>> used screen resolutions. In addition, a particular EDID data set may be
>> provided in the /lib/firmware directory and loaded via the firmware
>> interface. The name is passed to the kernel as module parameter of the
>> drm_kms_helper module either when loaded
>>   options drm_kms_helper edid_firmware=edid/1280x1024.bin
>> or as kernel commandline parameter
>>   drm_kms_helper.edid_firmware=edid/1280x1024.bin
>
> Windows allow vendor to override eddid based on 3 bytes manufacturer
> and product code.
This may solve the situation when a particular monitor lies about the
required setting or its EDID data set has an invalid CRC. However, this
does not solve the situation when we do not get any useful EDID
information, because something is totally broken. This also applies to
the KVM situation when the KVM sends EDID data that are totally
unrelated to the monitor at the other side of the KVM.

> Seems a reasonnable approach to follow.
I am not yet convinced.

	-Carsten.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/