linux-kernel - [RFC]blk: mark discard request sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 15:40:14 +0800
From:	Shaohua Li <shli@...nel.org>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"axboe@...nel.dk" <axboe@...nel.dk>,
	Vivek Goyal <vgoyal@...hat.com>
Subject: [RFC]blk: mark discard request sync


Subject: blk: mark discard request sync

discard is called in jbd for example. If discard is slowed down, all
file operations could be impacted (eg, journal is full). And we always
wait for discard to finish. So looks we should mark discard as sync.

Signed-off-by: Shaohua Li <shli@...ionio.com>
---
  block/blk-lib.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/block/blk-lib.c
===================================================================
--- linux.orig/block/blk-lib.c	2012-03-16 10:20:49.621517546 +0800
+++ linux/block/blk-lib.c	2012-03-16 10:21:55.901517256 +0800
@@ -42,7 +42,7 @@ int blkdev_issue_discard(struct block_de
  {
  	DECLARE_COMPLETION_ONSTACK(wait);
  	struct request_queue *q = bdev_get_queue(bdev);
-	int type = REQ_WRITE | REQ_DISCARD;
+	int type = REQ_WRITE | REQ_DISCARD | REQ_SYNC;
  	unsigned int max_discard_sectors;
  	struct bio_batch bb;
  	struct bio *bio;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/