linux-kernel - Re: stable-3.0: s390 build breakage [was: Linux 3.0.24]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 13:52:29 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Willy Tarreau <w@....eu>
CC:	Greg KH <gregkh@...uxfoundation.org>, Jiri Slaby <jslaby@...e.cz>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, stable@...r.kernel.org, lwn@....net,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: stable-3.0: s390 build breakage [was: Linux 3.0.24]

On 03/15/2012 05:51 PM, Jiri Slaby wrote:
> On 03/15/2012 05:49 PM, Willy Tarreau wrote:
>> On Thu, Mar 15, 2012 at 09:46:24AM -0700, Greg KH wrote:
>>> On Thu, Mar 15, 2012 at 05:27:26PM +0100, Jiri Slaby wrote:
>>>> On 03/15/2012 11:48 AM, Jiri Slaby wrote:
>>>>> On 03/12/2012 09:34 PM, Greg KH wrote:
>>>>>> I'm announcing the release of the 3.0.24 kernel.
>>>>> ...
>>>>>> Heiko Carstens (1): compat: fix compile breakage on s390
>>>>>
>>>>> It looks like we need the same fix as for 2.6.32.59:
>>>>> arch/s390/kernel/setup.c: In function 'setup_addressing_mode':
>>>>> arch/s390/kernel/setup.c:328: error: 'PSW32_ASC_PRIMARY' undeclared
>>>>> (first use in this function)
>>>>> arch/s390/kernel/setup.c:328: error: (Each undeclared identifier is
>>>>> reported only once
>>>>> arch/s390/kernel/setup.c:328: error: for each function it appears in.)
>>>>
>>>> And when that one is fixed, there is another error:
>>>> drivers/s390/char/fs3270.c: In function 'fs3270_ioctl':
>>>> drivers/s390/char/fs3270.c:335: error: implicit declaration of function
>>>> 'compat_ptr'
>>>> drivers/s390/char/fs3270.c:335: warning: assignment makes pointer from
>>>> integer without a cast
>>>
>>> Ick, have a patch for this?
>>
>> This one is declared in arch/s390/include/asm/compat.h:
>>
>> static inline void __user *compat_ptr(compat_uptr_t uptr)
>> {
>>         return (void __user *)(unsigned long)(uptr & 0x7fffffffUL);
>> }
>>
>> In 2.6.32, fs3270.c include linux/compat.h. In 3.0 it includes asm/compat.h
>> instead. I would have thought the later would have been enough.
> 
> But it was changed to linux/compat.h in 3.0.24 -- that's why it doesn't
> build. So the same fix as for setup.c should help here.

It is attached. With that patch (and the previous one), s390 builds fine
now.

thanks,
-- 
js

View attachment "compat-Re-add-missing-asm-compat.h-include.patch" of type "text/x-patch" (961 bytes)