linux-kernel - Re: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 14:19:32 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Christian Lamparter <chunkeey@...glemail.com>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	Kay Sievers <kay@...y.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	Linux PM mailing list <linux-pm@...r.kernel.org>,
	skannan@...eaurora.org, Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH] firmware loader: don't cancel _nowait requests when
 helper is not yet available

On Fri, Mar 16, 2012 at 2:14 PM, Christian Lamparter
<chunkeey@...glemail.com> wrote:
>
> Because As far as I know "driver_init();" is called before
> "usermodehelper_enable();" in "do_basic_setup()".
> So, theoretical these people should see the same WARNINGs
> and read the comment about suspend/resume and I'm sure
> they will be thinking: WTF!

Just make the explanation be simple:

  "The system is not 8in a fully initialized state, and you cannot
load firmware at this point. User mode is not running, not all devices
have necessarily been initialized, user space applications may or may
not be frozen, and the filesystem may or may not exist yet. Loading
firmware is buggy under these circumstances. Go away"

Don't try to go into any details. The "you can race with freezer" is
too much detail. Even "suspend/resume" is too much detail. The fact
is, the system just isn't ready yet. The details are almost entirely
irrelevant, at best they can be examples of some things that can cause
problems.

                      Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/