linux-kernel - Re: [PATCH] firmware loader: don't cancel _nowait requests when helper is not yet available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 16 Mar 2012 22:51:32 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Saravana Kannan <skannan@...eaurora.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Greg KH <gregkh@...uxfoundation.org>,
	Christian Lamparter <chunkeey@...glemail.com>,
	linux-kernel@...r.kernel.org,
	"Srivatsa S. Bhat" <srivatsa.bhat@...ux.vnet.ibm.com>,
	alan@...rguk.ukuu.org.uk,
	Linux PM mailing list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] firmware loader: don't cancel _nowait requests when
 helper is not yet available

On Fri, Mar 16, 2012 at 7:47 PM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> -       if (WARN_ON(usermodehelper_is_disabled())) {
> +       if (is_sleep_task()) {
>                dev_err(device, "firmware: %s will not be loaded\n", name);

Stop these idiotic games already!

It's very simple: you cannot load firmware while the system is not
readt. Your moronic "let's change the test to something else" is
entirely and utterly misguided and totally misses the point.

It's not about sleeping, and it's not about anything even *remotely*
about that. Stop the idiocy already.

How hard is it to understand? How many times do people have to tell you?

That warning is very much valid during bootup, and that warning has
been *seen* during bootup. For example, try to compile in most
wireless drivers as non-modular, and that warning *has* to trigger.

Rafael, please consider everything along these *IDIOTIC* lines
completely NAK'ed. In fact, until Stephen starts showing any sign of
understanding that it's not about just some random small detail, just
ignore anything and everything from him.

Stephen, you've been told multiple times that that WARN_ON() is
correct. Until you understand that, just stop sending these entirely
random patches that change it to something completely wrong.

How hard can it be to understand that you cannot and must not load
firmware when the system isn't up-and-running.

And *dammit*, the fact that you send these kinds of completely
nonsensical patches that seem to think that "up-and-running" is just
about suspend (and not bootup, for example), all you are showing is
that you don't understand the problem. Stop, think, and read the
emails that have been in this thread and that have explained how it
*could* be solved.

Until you do that, any patch you send is just worthless. Really.

                     Linus

                              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/