lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Mar 2012 13:26:02 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Tejun Heo <tj@...nel.org> CC: glommer@...allels.com, lizf@...fujitsu.com, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org, fweisbec@...il.com, rni@...gle.com, ctalbott@...gle.com, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...e.cz>, Balbir Singh <bsingharora@...il.com>, Hugh Dickins <hughd@...gle.com>, Greg Thelen <gthelen@...gle.com> Subject: Re: [PATCH 06/10] cgroup: convert memcg controller to the new cftype interface (2012/03/17 8:35), Tejun Heo wrote: > Convert memcg to use the new cftype based interface. memcg is rather > special in that > > * memsw_cgroup_files creation is dependent on do_swap_account. > > * ->populate() is abused for mem_cgroup_sockets_init(). > > memsw_cgroup_files is converted to use CGROUP_SUBSYS_CFTYPES_COND(), > where the condition is really_do_swap_account. > > ->populate() is preserved for register_kmem_files() invocation but I > strongly urge moving the initialization to the tail of ->create(). If > there's something which can't be done from ->create(), which isn't > clear from the comment, please let me know. > Okay, then, cgroup files are created in kernel/cgroup.c and memcg just registers entries. > Signed-off-by: Tejun Heo <tj@...nel.org> > Cc: Johannes Weiner <hannes@...xchg.org> > Cc: Michal Hocko <mhocko@...e.cz> > Cc: Balbir Singh <bsingharora@...il.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> > Cc: Glauber Costa <glommer@...allels.com> > Cc: Hugh Dickins <hughd@...gle.com> > Cc: Greg Thelen <gthelen@...gle.com> > --- > mm/memcontrol.c | 31 ++++++------------------------- > net/ipv4/tcp_memcontrol.c | 8 ++++---- > 2 files changed, 10 insertions(+), 29 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index ae2f0a8..f2221ce 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4665,7 +4665,9 @@ static struct cftype mem_cgroup_files[] = { > .mode = S_IRUGO, > }, > #endif > + { }, /* terminate */ > }; > +CGROUP_SUBSYS_CFTYPES(mem_cgroup_subsys, mem_cgroup_files); > > #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP > static struct cftype memsw_cgroup_files[] = { > @@ -4694,20 +4696,10 @@ static struct cftype memsw_cgroup_files[] = { > .trigger = mem_cgroup_reset, > .read_u64 = mem_cgroup_read, > }, > + { } /* terminate */ > }; > - > -static int register_memsw_files(struct cgroup *cont, struct cgroup_subsys *ss) > -{ > - if (!do_swap_account) > - return 0; > - return cgroup_add_files(cont, ss, memsw_cgroup_files, > - ARRAY_SIZE(memsw_cgroup_files)); > -}; > -#else > -static int register_memsw_files(struct cgroup *cont, struct cgroup_subsys *ss) > -{ > - return 0; > -} > +CGROUP_SUBSYS_CFTYPES_COND(mem_cgroup_subsys, memsw_cgroup_files, > + really_do_swap_account); I'm sorry but why you use really_do_swap_account instead of do_swap_account ? Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists