lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Mar 2012 13:42:39 +0900 From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> To: Tejun Heo <tj@...nel.org> CC: glommer@...allels.com, lizf@...fujitsu.com, containers@...ts.linux-foundation.org, cgroups@...r.kernel.org, linux-kernel@...r.kernel.org, fweisbec@...il.com, rni@...gle.com, ctalbott@...gle.com, Johannes Weiner <hannes@...xchg.org>, Michal Hocko <mhocko@...e.cz>, Balbir Singh <bsingharora@...il.com>, Hugh Dickins <hughd@...gle.com>, Greg Thelen <gthelen@...gle.com> Subject: Re: [PATCH 06/10] cgroup: convert memcg controller to the new cftype interface (2012/03/20 1:10), Tejun Heo wrote: > Hello, > > On Mon, Mar 19, 2012 at 01:26:02PM +0900, KAMEZAWA Hiroyuki wrote: >>> +CGROUP_SUBSYS_CFTYPES_COND(mem_cgroup_subsys, memsw_cgroup_files, >>> + really_do_swap_account); >> >> >> I'm sorry but why you use really_do_swap_account instead of do_swap_account ? > > Because do_swap_account is initialized too late. > CGROUP_SUBSYS_CFTYPES() are processed via fs_initcall(). AFAICS, > do_swap_account may not have been initialized by then. Also, if memcg > as whole is disabled, it doesn't matter whether those files are > registered or not, right? We probably need some comment there tho. > I think creating file based on really_do_swap_account is wrong. (I'm sorry for this complication.) How about creating this file unconditionally ? Returning -ENOTSUP in memcg's handler will work well...anyway it's configured, no reason to show them is bad. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists