linux-kernel - Re: Regression introduced by bfcfaa77bdf0f775263e906015982a608df01c76 (vfs: use 'unsigned long' accesses for dcache name comparison and hashing)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Mar 2012 20:10:27 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Eric Paris <eparis@...isplace.org>
Cc:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com
Subject: Re: Regression introduced by
 bfcfaa77bdf0f775263e906015982a608df01c76 (vfs: use 'unsigned long' accesses
 for dcache name comparison and hashing)

On Thu, Mar 22, 2012 at 04:03:45PM -0400, Eric Paris wrote:
> Reverting this patch also fixed the spurious ENOENT problems (and
> related boot failures) from SELinux.
> 
> Easy reproducer with SELinux enabled (although might I suggest
> permissive/enforcing=0 since the box can't boot otherwise):
> 
> compute_create system_u:system_r:kernel_t:s0
> system_u:object_r:init_exec_t:s0 process
> 
> If you get back system_u:object_r:init_exec_t:s0 it failed and you'll
> see under strace the ENOENT stat() failure.
> 
> If you get back system_u:object_r:init_t:s0 it means it worked...

Unless I'm misreading that code, the problem should hit on names with
length being a multiple of 8...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/