lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 24 Mar 2012 14:31:10 +0400 From: Anton Vorontsov <anton.vorontsov@...aro.org> To: Andrew Morton <akpm@...ux-foundation.org>, Oleg Nesterov <oleg@...hat.com> Cc: Russell King <linux@....linux.org.uk>, Mike Frysinger <vapier@...too.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Richard Weinberger <richard@....at>, Paul Mundt <lethal@...ux-sh.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, John Stultz <john.stultz@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org, linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org, user-mode-linux-devel@...ts.sourceforge.net, linux-mm@...ck.org Subject: [PATCH 09/10] um: Properly check all process' threads for a live mm kill_off_processes() might miss a valid process, this is because checking for process->mm is not enough. Process' main thread may exit or detach its mm via use_mm(), but other threads may still have a valid mm. To catch this we use find_lock_task_mm(), which walks up all threads and returns an appropriate task (with task lock held). Suggested-by: Oleg Nesterov <oleg@...hat.com> Signed-off-by: Anton Vorontsov <anton.vorontsov@...aro.org> --- arch/um/kernel/reboot.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c index 1411f4e..3d15243 100644 --- a/arch/um/kernel/reboot.c +++ b/arch/um/kernel/reboot.c @@ -6,6 +6,7 @@ #include "linux/sched.h" #include "linux/spinlock.h" #include "linux/slab.h" +#include "linux/oom.h" #include "kern_util.h" #include "os.h" #include "skas.h" @@ -25,13 +26,13 @@ static void kill_off_processes(void) read_lock(&tasklist_lock); for_each_process(p) { - task_lock(p); - if (!p->mm) { - task_unlock(p); + struct task_struct *t; + + t = find_lock_task_mm(p); + if (!t) continue; - } - pid = p->mm->context.id.u.pid; - task_unlock(p); + pid = t->mm->context.id.u.pid; + task_unlock(t); os_kill_ptraced_process(pid, 1); } read_unlock(&tasklist_lock); -- 1.7.9.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists