linux-kernel - Re: linux-next: build failure after merge of the scsi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Mar 2012 07:07:21 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Alexey Dobriyan <adobriyan@...il.com>
Subject: Re: linux-next: build failure after merge of the scsi tree

On Mon, Mar 26, 2012 at 08:57:21AM +0100, James Bottomley wrote:
> On Mon, 2012-03-26 at 12:17 +1100, Stephen Rothwell wrote:
> > Hi James,
> > 
> > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > drivers/staging/keucr/scsiglue.c:349:2: error: unknown field 'proc_info' specified in initializer
> > drivers/staging/rts_pstor/rtsx.c:258:2: error: unknown field 'proc_info' specified in initializer
> > drivers/staging/rts5139/rts51x_scsi.c:2190:2: error: unknown field 'proc_info' specified in initializer
> > 
> > Caused by commit 104c4fe25dc9 ("[SCSI] remove scsi_host_template::proc_info").
> > 
> > Since this is a staging driver, I applied these following patches:
> 
> Yes, that looks about right, thanks.  We haven't seen anything about
> these drivers on the SCSI list, so I've no idea where they are in
> development.

Why is new patches going into your tree right now, during the 3.4 merge
window?  API changes should have happened weeks ago, to let others fix
up things like this.

As for the "where they are in development", they vary, but, a simple
grep should have shown you that these in-kernel drivers should also be
fixed up, or at the least, give me the heads up to let me do it for you.

Care to send me the patch that causes this problem so I can create a fix
for this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/