linux-kernel - Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform device definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Mar 2012 18:23:47 -0700
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	Joerg Roedel <joro@...tes.org>
CC:	Kukjin Kim <kgene.kim@...sung.com>,
	Subash Patel <subash.ramaswamy@...aro.org>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Younglak Kim' <younglak1004.kim@...sung.com>,
	iommu@...ts.linux-foundation.org,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Sanghyun Lee' <sanghyun75.lee@...sung.com>,
	Cho KyongHo <pullip.cho@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform device
 definitions

Joerg Roedel wrote:
> On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote:
>> Anyway Joerg, how do you want to handle this? Do you want to pick up
>> 1/2/3 all of them in your tree? If so, 2nd patch should be on top of
>> some samsung topic stuff.
>
> Since patch 2 only applies to the Samsung tree, it is best to carry
> this in your tree for merging. Feel free to add my Acked-by to patch 3.
> But any further patches for the Exynos IOMMU drivers should go through
> my tree after it is merged.
>

Hi Joerg,

Now that 1st and 2nd can be applied cleanly into latest mainline. But 
unfortunately, I have no chance to send them to Linus now and I'm not 
sure you can do it during this merge window. If it is possible, please 
keep going on with my ack.

KyongHo, just note, happens follwoing complaint with checkpatch, but I'm 
not sure this should be fixed right now. I think, if required, we can 
fix it later.

ERROR: Macros with complex values should be enclosed in parenthesis
#698: FILE: arch/arm/mach-exynos/dev-sysmmu.c:64:
+#define DEFINE_SYSMMU_RESOURCE(core, mem, irq)                         \
+       DEFINE_RES_MEM_NAMED(core##_PA_SYSMMU_##mem, SZ_4K, #mem),      \
+       DEFINE_RES_IRQ_NAMED(core##_IRQ_SYSMMU_##irq##_0, #mem)

ERROR: Macros with complex values should be enclosed in parenthesis
#702: FILE: arch/arm/mach-exynos/dev-sysmmu.c:68:
+#define SYSMMU_RESOURCE_DEFINE(core, ipname, mem, irq)                 \
+       SYSMMU_RESOURCE(core, ipname) {                                 \
+               DEFINE_SYSMMU_RESOURCE(core, mem, irq)                  \
+       }

WARNING: quoted string split across lines
#914: FILE: arch/arm/mach-exynos/dev-sysmmu.c:259:
+                               pr_err("%s: Failed to add device 
resources for "
+                                               "%s.%d\n", __func__,

total: 2 errors, 1 warnings, 1062 lines checked

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/