linux-kernel - Re: K7/Athlon Optimization Causes Build Fail on Kernel 3.3 i686

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 29 Mar 2012 22:46:23 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Matt Fleming <matt.fleming@...el.com>,
	Trevor Turner <turn3r.tr3v0r@...il.com>,
	Randy Dunlap <rdunlap@...otime.net>,
	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: K7/Athlon Optimization Causes Build Fail on Kernel 3.3 i686

On Thu, Mar 29, 2012 at 11:28:40AM -0700, H. Peter Anvin wrote:
> I like this one for urgent as a quick fix, but it doesn't solve the real
> problem which is that boot/compressed shouldn't pick up these macros at all.

But it does through:

<arch/x86/include/asm/string_32.h>:

...
static inline void *__memcpy3d(void *to, const void *from, size_t len)
{
	if (len < 512)
		return __memcpy(to, from, len);
	return _mmx_memcpy(to, from, len);
}

#define memcpy(t, f, n)				\
	(__builtin_constant_p((n))		\
	 ? __constant_memcpy3d((t), (f), (n))	\
	 : __memcpy3d((t), (f), (n)))

> It should be possible to build with MK7 (which is an optimization
> option) and EFI (a functionality option) since they don't inherently
> conflict.  It just doesn't necessarily have to happen *right now*.

I know, technically it is doable, but do you see a K7 box with an EFI
firmware? I, at least, don't think so... :-)

Now, if you think that those optimizations could be used on other boxes
which could sport EFI, then that's a whole another question...

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/