linux-kernel - Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when initializing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Apr 2012 19:36:45 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Sasha Levin <levinsasha928@...il.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugobjects: Use GFP_ATOMIC to allocate when
 initializing

On Sat, 31 Mar 2012, Sasha Levin wrote:

> During the init stage, we have only 1 cpu and run with IRQs disabled,
> we can't allocate with GFP_KERNEL.
> 
> This also fixes the related warning on boot.

Hrmm. This should not be the case. In early boot GFP_KERNEL
allocations should not trigger a warning when interrupts are
disabled. Which kind of warning are you observing ?

Thanks,

	tglx

 
> Signed-off-by: Sasha Levin <levinsasha928@...il.com>
> ---
>  lib/debugobjects.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/debugobjects.c b/lib/debugobjects.c
> index 0ab9ae8..ece5e06 100644
> --- a/lib/debugobjects.c
> +++ b/lib/debugobjects.c
> @@ -1020,7 +1020,7 @@ static int __init debug_objects_replace_static_objects(void)
>  	int i, cnt = 0;
>  
>  	for (i = 0; i < ODEBUG_POOL_SIZE; i++) {
> -		obj = kmem_cache_zalloc(obj_cache, GFP_KERNEL);
> +		obj = kmem_cache_zalloc(obj_cache, GFP_ATOMIC);
>  		if (!obj)
>  			goto free;
>  		hlist_add_head(&obj->node, &objects);
> -- 
> 1.7.8.5
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/