linux-kernel - Re: [linux-pm] [PATCH 17/76] thermal_sys: convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 1 Apr 2012 22:13:51 +0300
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Joe Perches <joe@...ches.com>
Cc:	eduardo.valentin@...com, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	Len Brown <len.brown@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jesper Juhl <jj@...osbits.net>, linux-kernel@...r.kernel.org
Subject: Re: [linux-pm] [PATCH 17/76] thermal_sys: convert printks to
 pr_<level>

Hello Joe,

On Fri, Mar 30, 2012 at 12:08:50PM -0700, Joe Perches wrote:
> On Fri, 2012-03-30 at 16:41 +0300, Eduardo Valentin wrote:
> > On Fri, Mar 30, 2012 at 06:13:20AM -0400, Len Brown wrote:
> > > From: Joe Perches <joe@...ches.com>
> > > Use the current logging style.
> []
> > We should get the struct dev in thermal_zone_device, I think it makes
> > more sense to use the dev_* helper functions.
> []
> > The orig argument could probably be changed to a thermal zone device
> > and the we use it's id as orig for the message.
> > What do you think?
> 
> dev_<level> should be used instead of pr_<level> when
> an appropriate struct device * is available.

Agreed that we need a struct device *. My comments are based on the fact
that you have one of it inside the struct therma_zone_device, field device.

Isn't that struct device appropriated enough to be used by the dev_* functions?

> 
> cheers, Joe
> 

Cheers,

Eduardo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/