lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 02 Apr 2012 09:18:55 +0800 From: Ren Mingxin <renmx@...fujitsu.com> To: Tejun Heo <tj@...nel.org> CC: Jens Axboe <axboe@...nel.dk>, "Michael S. Tsirkin" <mst@...hat.com>, Rusty Russell <rusty@...tcorp.com.au>, LKML <linux-kernel@...r.kernel.org>, SCSI <linux-scsi@...r.kernel.org>, KVM <kvm@...r.kernel.org>, VIRTUAL <virtualization@...ts.linux-foundation.org> Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming On 03/30/2012 11:38 PM, Tejun Heo wrote: > On Fri, Mar 30, 2012 at 08:26:06AM -0700, Tejun Heo wrote: >> On Fri, Mar 30, 2012 at 05:53:52PM +0800, Ren Mingxin wrote: >>> The current virtblk's naming algorithm only supports 263 disks. >>> If there are mass of virtblks(exceeding 263), there will be disks >>> with the same name. >>> >>> By renaming "sd_format_disk_name()" to "disk_name_format()" >>> and moving it into block core, virtio_blk can use this function to >>> support mass of disks. >>> >>> Signed-off-by: Ren Mingxin<renmx@...fujitsu.com> >> I guess it's already way too late but why couldn't they have been >> named vdD-P where both D and P are integers denoting disk number and > So, if a device name ends in digit the partition code adds delimiter > 'p' automatically and this is already in use by md. So, partitioned > md devices are named mdDpP where D and P are base 10 number indicating > the sequence like md12p4. So, let's please add comment that new > drivers should name their devices PREFIX%d where the sequence number > can be allocated by ida. > > Oh, got it. Just like md devices' names. -- Thanks, Ren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists