linux-kernel - Re: [PATCH] hpsa: use check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 03 Apr 2012 10:45:46 -0500
From:	Mike Miller <mike.miller@...com>
To:	Akinobu Mita <akinobu.mita@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	ISS StorageDev <iss_storagedev@...com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] hpsa: use check_signature

On 04/03/2012 12:38 AM, Akinobu Mita wrote:
> Use check_signature to find a signature in the mmio address.
>
> Signed-off-by: Akinobu Mita<akinobu.mita@...il.com>
> Cc: Mike Miller<mike.miller@...com>
> Cc: iss_storagedev@...com
> Cc: "James E.J. Bottomley"<JBottomley@...allels.com>
> Cc: linux-scsi@...r.kernel.org

Acked-by: Mike Miller <mike.miller@...com>

> ---
>   drivers/scsi/hpsa.c |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index ddbf5fe..c867eeb 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -3839,10 +3839,7 @@ static void __devinit hpsa_find_board_params(struct ctlr_info *h)
>
>   static inline bool hpsa_CISS_signature_present(struct ctlr_info *h)
>   {
> -	if ((readb(&h->cfgtable->Signature[0]) != 'C') ||
> -	    (readb(&h->cfgtable->Signature[1]) != 'I') ||
> -	    (readb(&h->cfgtable->Signature[2]) != 'S') ||
> -	    (readb(&h->cfgtable->Signature[3]) != 'S')) {
> +	if (!check_signature(h->cfgtable->Signature, "CISS", 4)) {
>   		dev_warn(&h->pdev->dev, "not a valid CISS config table\n");
>   		return false;
>   	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/