linux-kernel - Re: [PATCH] Use safe_halt() rather than halt() in acpi_idle_play

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Apr 2012 12:52:19 -0400
From:	Boris Ostrovsky <boris.ostrovsky@....com>
To:	Tony Luck <tony.luck@...el.com>
CC:	Len Brown <lenb@...nel.org>, <linux-acpi@...r.kernel.org>,
	<linux-pm@...ts.linux-foundation.org>,
	<linux-kernel@...r.kernel.org>, Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] Use safe_halt() rather than halt() in acpi_idle_play_deay()

On 04/03/12 12:37, Luck, Tony: <tony.luck@...el.com wrote:
> ACPI code is shared by arch/x86 and arch/ia64. ia64 doesn't provide a plain
> "halt()" function.  Use safe_halt() instead.
>
> Signed-off-by: Tony Luck<tony.luck@...el.com>
>
> ---
>
> E-mail discussion indicated this would be OK. Please check on x86
> before applying.

Tested-by: Boris Ostrovsky <boris.ostrovsky@....com>

-boris

>
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index b3447f6..f3decb3 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -786,7 +786,7 @@ static int acpi_idle_play_dead(struct cpuidle_device *dev, int index)
>   	while (1) {
>
>   		if (cx->entry_method == ACPI_CSTATE_HALT)
> -			halt();
> +			safe_halt();
>   		else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) {
>   			inb(cx->address);
>   			/* See comment in acpi_idle_do_entry() */
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/