[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 04 Apr 2012 13:08:04 +0200
From: Roland Stigge <stigge@...com.de>
To: Arnd Bergmann <arnd@...db.de>
CC: Grant Likely <grant.likely@...retlab.ca>, arm@...nel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linus.walleij@...ricsson.com
Subject: Re: [PATCH v2] gpio: Device tree support for LPC32xx
On 04/04/2012 10:48 AM, Arnd Bergmann wrote:
>> +#ifdef CONFIG_OF
>> +static struct of_device_id lpc32xx_gpio_of_match[] __devinitdata = {
>> + { .compatible = "nxp,lpc32xx-gpio", },
>> + { },
>> +};
>> +#endif
>> +
>> +static struct platform_driver lpc32xx_gpio_driver = {
>> + .driver = {
>> + .name = "lpc32xx-gpio",
>> + .owner = THIS_MODULE,
>> + .of_match_table = lpc32xx_gpio_of_match,
>> + },
>> + .probe = lpc32xx_gpio_probe,
>> +};
>
> The #ifdef above is not helpful, it will cause a build error in the
> of_match_table= assignment. Since the plan for this driver is to
> be devicetree-only, it would be appropriate to just remove the
> #ifdef, but adding of_match_ptr() is ok too.
I think I just forgot the of_match_ptr(). Will post an update with a
repo for gpio to pull from.
Thanks for the note!
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists