linux-kernel - Re: [PATCH v2] compiler.h: Include <linux/bug.h> to avoid build breakage with ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Apr 2012 16:29:24 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	Fabio Estevam <festevam@...il.com>, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, linux@....linux.org.uk,
	sam@...nborg.org, Fabio Estevam <fabio.estevam@...escale.com>,
	kernel@...gutronix.de
Subject: Re: [PATCH v2] compiler.h: Include <linux/bug.h> to avoid build
 breakage with ARRAY_SIZE()

Hello,

On Fri, Mar 02, 2012 at 09:22:02AM -0500, Paul Gortmaker wrote:
> On 12-03-01 10:13 PM, Fabio Estevam wrote:
> > On Thu, Mar 1, 2012 at 11:49 PM, Paul Gortmaker
> > <paul.gortmaker@...driver.com> wrote:
> > 
> >> Thanks, but no.
> >>
> >> You missed the whole point of my previous comments -- that being
> >> that we don't want to just jam headers into always-used headers.
> > 
> > Yes, it is not clear for me how to fix this build error. I got
> > different feedbacks from you, Russell and Sam.
> 
> Understood, there was some discussion there.  Anyways it is already
> dealt with in yesterday's linux-next tree, so you won't have the
> build failure anymore.
I hit that same problem in an not yet mainlined source file. A simple
file containing only:

	#include <linux/kernel.h>

	int array[3];

	int func(void)
	{
		return ARRAY_SIZE(array);
	}

fails to build on top of v3.4-rc1. Am I right that you saying "you won't
have the build failure anymore" means that each of these is now needed
to be fixed individually by adding

	#include <linux/bug.h>

? Otherwise it's not fixed for me.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/