linux-kernel - Re: [PATCH] userns: Replace netlink uses of cap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 4 Apr 2012 14:06:19 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Philipp Reisner <philipp.reisner@...bit.com>,
	Patrick McHardy <kaber@...sh.net>,
	Andrew Morgan <morgan@...nel.org>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	David Howells <dhowells@...hat.com>,
	Neil Brown <neilb@...e.de>,
	Michal Januszewski <spock@...too.org>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, linux-fbdev@...r.kernel.org,
	linux-raid@...r.kernel.org
Subject: Re: [PATCH] userns: Replace netlink uses of cap_raised with
 capable.

On Tue, 3 Apr 2012, Eric W. Biederman wrote:

> In the initial user_namespace the only difference between  between
> cap_raised(current_cap(), CAP_SYS_ADMIN) and capable(CAP_SYS_ADMIN)
> are a few sanity checks and the fact that capable(CAP_SYS_ADMIN)
> sets PF_SUPERPRIV if we use the capability.
> 
> Since we are going to be using root privilege setting PF_SUPERPRIV
> seems the right thing to do.

Agreed.

Reviewed-by: James Morris <james.l.morris@...cle.com>


- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/