lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 3 Apr 2012 20:49:40 -0400
From:	Josh Boyer <jwboyer@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Tanmay Inamdar <tinamdar@....com>, benh@...nel.crashing.org,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 3/5] powerpc: dts: klondike: Add UART nodes

On Tue, Apr 3, 2012 at 11:57 AM, Grant Likely <grant.likely@...retlab.ca> wrote:
> On Mon,  2 Apr 2012 12:09:05 +0530, Tanmay Inamdar <tinamdar@....com> wrote:
>> Adding UART nodes in Klondike device tree file.
>>
>> Signed-off-by: Tanmay Inamdar <tinamdar@....com>
>> ---
>> :100644 100644 4ff2852... d5bf2e1... M        arch/powerpc/boot/dts/klondike.dts
>>  arch/powerpc/boot/dts/klondike.dts |   24 ++++++++++++++++++++++++
>>  1 files changed, 24 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/powerpc/boot/dts/klondike.dts b/arch/powerpc/boot/dts/klondike.dts
>> index 4ff2852..d5bf2e1 100644
>> --- a/arch/powerpc/boot/dts/klondike.dts
>> +++ b/arch/powerpc/boot/dts/klondike.dts
>> @@ -222,6 +222,30 @@
>>                               #size-cells = <1>;
>>                               ranges;
>>                               clock-frequency = <0>;
>> +
>> +                             UART0: serial@...01000 {
>> +                                    device_type = "serial";
>> +                                    compatible = "ns16550";
>> +                                    reg = <0x50001000 0x00000100>;
>> +                                    virtual-reg = <0x50001000>;
>
> Why do you need virtual-reg?  The kernel should handle all iomapping
> properly without this.

Right.  It's been used for platforms that actually use the
zImage/treeImage wrapper for printf support, but this uses u-boot as
far as I know.  It shouldn't need it.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists