linux-kernel - Re: [PATCH] usb: host: tegra: re-arranging ehci functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Apr 2012 10:06:28 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
cc:	gregkh@...uxfoundation.org, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: host: tegra: re-arranging ehci functions

On Thu, 5 Apr 2012, Venu Byravarasu wrote:

> Re-arranged standard and tegra specific ehci functions
> into two separate groups, for more readability
> 
> Signed-off-by: Venu Byravarasu <vbyravarasu@...dia.com>
> ---
>  drivers/usb/host/ehci-tegra.c |   23 ++++++++++++-----------
>  1 files changed, 12 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index 3de48a2..96c942c 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -552,31 +552,32 @@ static const struct hc_driver tegra_ehci_hc_driver = {
>  	.description		= hcd_name,
>  	.product_desc		= "Tegra EHCI Host Controller",
>  	.hcd_priv_size		= sizeof(struct ehci_hcd),
> -
>  	.flags			= HCD_USB2 | HCD_MEMORY,
>  
> -	.reset			= tegra_ehci_setup,
> -	.irq			= ehci_irq,
> -
> +	/* standard ehci functions */
>  	.start			= ehci_run,
>  	.stop			= ehci_stop,
> -	.shutdown		= tegra_ehci_shutdown,
> -	.urb_enqueue		= ehci_urb_enqueue,
>  	.urb_dequeue		= ehci_urb_dequeue,
> -	.map_urb_for_dma	= tegra_ehci_map_urb_for_dma,
> -	.unmap_urb_for_dma	= tegra_ehci_unmap_urb_for_dma,
>  	.endpoint_disable	= ehci_endpoint_disable,
>  	.endpoint_reset		= ehci_endpoint_reset,
>  	.get_frame_number	= ehci_get_frame,
>  	.hub_status_data	= ehci_hub_status_data,
> -	.hub_control		= tegra_ehci_hub_control,
>  	.clear_tt_buffer_complete = ehci_clear_tt_buffer_complete,
> +	.relinquish_port	= ehci_relinquish_port,
> +	.port_handed_over	= ehci_port_handed_over,
> +
> +	/* modified ehci functions for tegra */
> +	.reset			= tegra_ehci_setup,
> +	.irq			= tegra_ehci_irq,

What happened here?  This patch is supposed to rearrange the entries, 
not change them.

> +	.shutdown		= tegra_ehci_shutdown,
> +	.map_urb_for_dma	= tegra_ehci_map_urb_for_dma,
> +	.unmap_urb_for_dma	= tegra_ehci_unmap_urb_for_dma,
> +	.hub_control		= tegra_ehci_hub_control,
> +	.urb_enqueue		= tegra_ehci_urb_enqueue,

Same here.

>  #ifdef CONFIG_PM
>  	.bus_suspend		= tegra_ehci_bus_suspend,
>  	.bus_resume		= tegra_ehci_bus_resume,
>  #endif
> -	.relinquish_port	= ehci_relinquish_port,
> -	.port_handed_over	= ehci_port_handed_over,
>  };

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/