linux-kernel - Re: [PATCH 2/2] ixgbe: add missing rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 05 Apr 2012 16:03:11 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Benjamin Poirier <bpoirier@...e.de>
Cc:	Alex Duyck <alexander.h.duyck@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	e1000-devel@...ts.sourceforge.net,
	Emil Tantilov <emil.s.tantilov@...el.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	John Fastabend <john.r.fastabend@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH 2/2] ixgbe: add missing rtnl_lock in PM resume path

On Thu, 2012-04-05 at 11:11 -0400, Benjamin Poirier wrote:
> Upon resume from standby, ixgbe may trigger the ASSERT_RTNL() in
> netif_set_real_num_tx_queues(). The call stack is:
>         netif_set_real_num_tx_queues
>         ixgbe_set_num_queues
>         ixgbe_init_interrupt_scheme
>         ixgbe_resume
> 
> Signed-off-by: Benjamin Poirier <bpoirier@...e.de>
> 
> ---
> Unlike patch 1 for igb, we cannot lock rtnl closer to the point where
> netif_set_real_num_tx_queues() is called because
> ixgbe_init_interrupt_scheme()
> is also called by the dcb code, already under rtnl.
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-) 

Thanks Benjamin, I will add the patch to my igb queue of patches.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)