linux-kernel - Re: [PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 8 Apr 2012 10:43:13 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Anton Vorontsov <anton.vorontsov@...aro.org>
Cc:	Greg KH <gregkh@...uxfoundation.org>, San Mehat <san@...gle.com>,
	Colin Cross <ccross@...roid.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	kernel-team@...roid.com, linaro-kernel@...ts.linaro.org,
	linux-kernel@...r.kernel.org, Chris Metcalf <cmetcalf@...era.com>
Subject: Re: [PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

On Tue, Feb 7, 2012 at 06:13, Anton Vorontsov
<anton.vorontsov@...aro.org> wrote:
> This patch fixes UML build:
>
>    CC      drivers/staging/android/ram_console.o
>  drivers/staging/android/ram_console.c: In function
>  'ram_console_driver_probe':
>  drivers/staging/android/ram_console.c:358:2: error: implicit declaration
>  of function 'ioremap' [-Werror=implicit-function-declaration]
>  cc1: some warnings being treated as errors
>  make[3]: *** [drivers/staging/android/ram_console.o] Error 1
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@...aro.org>
> ---
>  drivers/staging/android/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index becf711..2054ccb 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -27,6 +27,7 @@ config ANDROID_LOGGER
>
>  config ANDROID_RAM_CONSOLE
>        bool "Android RAM buffer console"
> +       depends on !S390 && !UML

Shouldn't that be "depends on HAS_IOMEM" instead?
I guess it also break on tile, which is the third NO_IOMEM arch?

>        default n

Superfluous, "n" is the default.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/