linux-kernel - bind() call in cgroup's css structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Apr 2012 10:59:56 -0300
From:	Glauber Costa <glommer@...allels.com>
To:	Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>,
	Paul Turner <pjt@...gle.com>, <cgroups@...r.kernel.org>,
	"devel@...nvz.org" <devel@...nvz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: bind() call in cgroup's css structure

Hello Tejun,

During your cgroup refactor, I was wondering if you have any plans to 
get rid of the bind() callback that is called when hierarchies are moved?

At least in tree, there seems to be no users for that.
I actually planned to use it myself, to start or remove a jump label
when cpuacct and cpu cgroups were comounted.

Problem is, because we have some calls in the cpuset cgroup from inside 
the cpu hotplug handler, we end up taking the almighty cgroup_mutex from 
inside the cpu_hotplug.lock.

jump labels take it in most arches through the get_online_cpus() 
function call. This means we effectively can't apply jump labels with 
the cgroup_mutex held, which is the case throughout the whole bind() call.

All that explained, I figured I might as well ask before I attempted a 
solution to that myself: as much as populate(), bind seems to be one of 
the overly complicated callbacks, designed for a scenario in which 
everything can come and go at will, which is something we're trying to fix.

thanks in advance for your answer!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/