lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 09 Apr 2012 11:47:51 +0800 From: Ren Mingxin <renmx@...fujitsu.com> To: "Michael S. Tsirkin" <mst@...hat.com> CC: Tejun Heo <tj@...nel.org>, James Bottomley <James.Bottomley@...senPartnership.com>, Jens Axboe <axboe@...nel.dk>, KVM <kvm@...r.kernel.org>, SCSI <linux-scsi@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, VIRTUAL <virtualization@...ts.linux-foundation.org> Subject: Re: [PATCH 4/4] virtio_blk: use disk_name_format() to support mass of disks naming On 04/04/2012 04:01 PM, Michael S. Tsirkin wrote: > On Mon, Apr 02, 2012 at 12:00:45PM -0700, Tejun Heo wrote: >> On Mon, Apr 02, 2012 at 11:56:18AM -0700, James Bottomley wrote: >>> So if we're agreed no other devices going forwards should ever use this >>> interface, is there any point unifying the interface? No matter how >>> many caveats you hedge it round with, putting the API in a central place >>> will be a bit like a honey trap for careless bears. It might be safer >>> just to leave it buried in the three current drivers. >> Yeah, that was my hope but I think it would be easier to enforce to >> have a common function which is clearly marked legacy so that new >> driver writers can go look for the naming code in the existing ones, >> find out they're all using the same function which is marked legacy >> and explains what to do for newer drivers. > I think I'm not the only one to be confused about the > preferred direction here. > James, do you agree to the approach above? > > It would be nice to fix virtio block for 3.4, so > how about this: > - I'll just apply the original bugfix patch for 3.4 - > it only affects virtio Sorry, about only affects virtio, I'm not very clear here: 1) Just duplicate the disk name format function in virtio_blk like the original patch: https://lkml.org/lkml/2012/3/28/45 2) Move the disk name format function into block core like this patch series but only affects virtio(not affect mtip32xx). Do you mean the 2) one or something else? > - Ren will repost the refactoring patch on top, and we can > keep up the discussion > > Ren if you agree, can you make this a two patch series please? > Sure. -- Thanks, Ren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists