linux-kernel - Re: [PATCH] virtio_ring: remove unused code in virtqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Apr 2012 16:48:20 +0800
From:	Zhi Yong Wu <zwu.kernel@...il.com>
To:	Stefan Hajnoczi <stefanha@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au,
	Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
Subject: Re: [PATCH] virtio_ring: remove unused code in virtqueue_notify()

On Fri, Apr 13, 2012 at 4:45 PM, Stefan Hajnoczi
<stefanha@...ux.vnet.ibm.com> wrote:
> On Fri, Apr 13, 2012 at 11:26:03AM +0800, zwu.kernel@...il.com wrote:
>> From: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>>
>> Signed-off-by: Zhi Yong Wu <wuzhy@...ux.vnet.ibm.com>
>> ---
>>  drivers/virtio/virtio_ring.c |    2 --
>>  1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index 5aa43c3..c6a54e6 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -343,8 +343,6 @@ EXPORT_SYMBOL_GPL(virtqueue_kick_prepare);
>>   */
>>  void virtqueue_notify(struct virtqueue *_vq)
>>  {
>> -     struct vring_virtqueue *vq = to_vvq(_vq);
>> -
>>       /* Prod other side to tell it about changes. */
>>       vq->notify(_vq);
>
> vq->notify() uses 'vq'.  How does this work?
sorry, i missed vq->notify. thanks
>
> Stefan
>



-- 
Regards,

Zhi Yong Wu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/