linux-kernel - Re: [PATCH] ARM: i.mx35 increase dma consistent region size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Apr 2012 17:11:34 +0200 (CEST)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Sascha Hauer <s.hauer@...gutronix.de>
cc:	Alex Gershgorin <alexg@...rolight.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: i.mx35 increase dma consistent region size

On Fri, 13 Apr 2012, Sascha Hauer wrote:

> On Wed, Apr 11, 2012 at 09:01:14PM +0300, Alex Gershgorin wrote:
> > The default size of the consistent DMA region is 2MB
> > without this patch, attempt to allocate more than 2MB
> > is causing allocation failure
> > 
> > Signed-off-by: Alex Gershgorin <alexg@...rolight.com>
> > ---
> >  arch/arm/mach-imx/mm-imx3.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/mm-imx3.c b/arch/arm/mach-imx/mm-imx3.c
> > index 7412738..a2c0c7d 100644
> > --- a/arch/arm/mach-imx/mm-imx3.c
> > +++ b/arch/arm/mach-imx/mm-imx3.c
> > @@ -201,6 +201,7 @@ static struct map_desc mx35_io_desc[] __initdata = {
> >  void __init mx35_map_io(void)
> >  {
> >  	iotable_init(mx35_io_desc, ARRAY_SIZE(mx35_io_desc));
> > +	init_consistent_dma_size(SZ_8M);
> 
> I don't know what to think about this. You probably have a board with
> camera support and thus need bigger buffers, right? Nevertheless this
> patch affects all i.MX35 users, even the ones without camera support.
> 
> Another possibility would be to make this board specific.

Isn't this what other (including i.MX3*) boards use arm_memblock_steal() 
for?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/