linux-kernel - Re: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 11:46:49 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Dong Aisheng <aisheng.dong@...escale.com>
Cc:	Dong Aisheng <dongas86@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linus.walleij@...ricsson.com, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, rob.herring@...xeda.com,
	kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver

On Mon, Apr 16, 2012 at 11:47:14AM +0800, Dong Aisheng wrote:
...
> Good suggestion.
> I can do it and it's easy to change.
> But as i said above, before the dtc macro support is available, the pinctrl
> setting in dts file will be hard to read since it's all raw data.
> It becomes
> fsl,pins = <1 2 3 4 5 6 ....>;
> People have to search the binding doc to see what the data means.
> 
It does not make the thing any worse.  You were asking people to search
pinctrl-imx6q.c for the meaning of the following.

  fsl,mux = <0 0 1 1 1 1 1 1 1 1>;

IMO, it makes a bit more sense to look at binding doc than code to
understand the dts file.

> The question is how long the dtc macro support will be available?
> I'm very willing to do like as you said if it's just a short time.
> But if it's long time, do we still want to lose the readability right now?
> 
The point is with my suggestion taken, we do not need to change code
when the dtc macro support is available.

-- 
Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/