linux-kernel - Re: [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 09:19:59 +0800
From:	Ian Kent <raven@...maw.net>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	kernel-janitors@...r.kernel.org, autofs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/autofs4/dev-ioctl.c: add missing free_dev_ioctl

On Sat, 2012-04-14 at 11:48 +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Free param as done in the other error-handling code.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Oops!
Acked-by: Ian Kent <raven@...maw.net>

> 
> ---
>  fs/autofs4/dev-ioctl.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
> index 9dacb85..f99c2ce 100644
> --- a/fs/autofs4/dev-ioctl.c
> +++ b/fs/autofs4/dev-ioctl.c
> @@ -651,7 +651,8 @@ static int _autofs_dev_ioctl(unsigned int command, struct autofs_dev_ioctl __use
>  	fn = lookup_dev_ioctl(cmd);
>  	if (!fn) {
>  		AUTOFS_WARN("unknown command 0x%08x", command);
> -		return -ENOTTY;
> +		err = -ENOTTY;
> +		goto out;
>  	}
>  
>  	fp = NULL;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe autofs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/