linux-kernel - Re: [PATCH] fs/fuse: Convert to kstrtoul_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 18 Apr 2012 17:43:46 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Peter Huewe <peterhuewe@....de>
Cc:	fuse-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] fs/fuse: Convert to kstrtoul_from_user

Peter Huewe <peterhuewe@....de> writes:

> This patch replaces the code for getting an number from a
> userspace buffer by a simple call to kstroul_from_user.
> This makes it easier to read and less error prone.

Thanks, applied.

Miklos

>
> Signed-off-by: Peter Huewe <peterhuewe@....de>
> ---
>  fs/fuse/control.c |   10 ++--------
>  1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/fs/fuse/control.c b/fs/fuse/control.c
> index 42593c5..03ff5b1 100644
> --- a/fs/fuse/control.c
> +++ b/fs/fuse/control.c
> @@ -75,19 +75,13 @@ static ssize_t fuse_conn_limit_write(struct file *file, const char __user *buf,
>  				     unsigned global_limit)
>  {
>  	unsigned long t;
> -	char tmp[32];
>  	unsigned limit = (1 << 16) - 1;
>  	int err;
>  
> -	if (*ppos || count >= sizeof(tmp) - 1)
> -		return -EINVAL;
> -
> -	if (copy_from_user(tmp, buf, count))
> +	if (*ppos)
>  		return -EINVAL;
>  
> -	tmp[count] = '\0';
> -
> -	err = strict_strtoul(tmp, 0, &t);
> +	err = kstrtoul_from_user(buf, count, 0, &t);
>  	if (err)
>  		return err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/