linux-kernel - Re: [PATCH] staging: olpc_dcon.c: checkpatch.pl and style fixups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Apr 2012 16:30:04 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	Andres Salomon <dilinger@...ued.net>,
	Jordan Crouse <jordan@...micpenguin.net>,
	Chris Ball <cjb@...top.org>,
	Jon Nettleton <jon.nettleton@...il.com>,
	Valentin Rothberg <valentinrothberg@...glemail.com>,
	Wolfram Sang <w.sang@...gutronix.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: olpc_dcon.c: checkpatch.pl and style fixups

On Sun, Apr 15, 2012 at 12:53:04AM +0200, Jesper Juhl wrote:
> This patch removes the few checkpatch.pl issues that are currently
> reported for this file.
> 
> It makes these changes:
> 
> 1. Quoted strings that were broken over multiple lines are put on a
>    single line for easier grep'ability.

Woah, no, a patch should only do one single thing.

If you have to list what it does, you are not doing it correctly.

And, as this patch shows, people liked part of it, but not others, so
you had to redo it.  If you had split this up into individual patches, I
could have just accepted those and not the others.

So please, always break your patches up into the proper pieces.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/