linux-kernel - Re: [PATCH 1/1] Added GenesysLogic BW Microscope device id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 21 Apr 2012 17:07:04 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Renzo Dani <arons7@...il.com>
Cc:	mchehab@...radead.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Added GenesysLogic BW Microscope device id

Hi Renzo,

On Friday 20 April 2012 20:28:43 Renzo Dani wrote:
> From: Renzo Dani <arons7@...il.com>
> 
> Signed-off-by: Renzo Dani <arons7@...il.com>

Thank you for the patch.

> ---
>  drivers/media/video/uvc/uvc_driver.c |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/uvc/uvc_driver.c
> b/drivers/media/video/uvc/uvc_driver.c index 1d13172..b8c94b4 100644
> --- a/drivers/media/video/uvc/uvc_driver.c
> +++ b/drivers/media/video/uvc/uvc_driver.c
> @@ -2176,7 +2176,16 @@ static struct usb_device_id uvc_ids[] = {
>  	  .bInterfaceSubClass	= 1,
>  	  .bInterfaceProtocol	= 0,
>  	  .driver_info		= UVC_QUIRK_STREAM_NO_FID },
> -	/* Hercules Classic Silver */
> +	/* Genesys Logic USB 2.0 BW Microscope */
> +        { .match_flags          = USB_DEVICE_ID_MATCH_DEVICE
> +                                | USB_DEVICE_ID_MATCH_INT_INFO,
> +          .idVendor             = 0x05e3,
> +          .idProduct            = 0x0511,
> +          .bInterfaceClass      = USB_CLASS_VIDEO,
> +          .bInterfaceSubClass   = 1,
> +          .bInterfaceProtocol   = 0,

Please use tabs instead of space to indent the code. Running 
scripts/checkpatch.pl on the patch before sending it catches this kind of 
issues, it's thus a good practice to do so. As the patch is small I've fixed 
the issue myself, there's no need to resubmit it.

> +          .driver_info          = UVC_QUIRK_STREAM_NO_FID },

I suppose you have tested the device without this patch and that it didn't 
work. Could you please confirm that ? Could you please also send me the output 
of

lsusb -v -d 05e3:0511

> +        /* Hercules Classic Silver */
>  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE
> 
>  				| USB_DEVICE_ID_MATCH_INT_INFO,
> 
>  	  .idVendor		= 0x06f8,

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/