linux-kernel - Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c: add missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Apr 2012 15:25:14 -0400
From:	Sean MacLennan <seanm@...nm.ca>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:
 add missing free_netdev

On Sun, 22 Apr 2012 14:02:13 +0200
Julia Lawall <Julia.Lawall@...6.fr> wrote:

> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Free dev on failure as done elsewhere in the function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_module.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c index
> e3d47bc..82d4bf6 100644 ---
> a/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c +++
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_module.c @@ -161,7
> +161,7 @@ struct net_device *alloc_ieee80211(int sizeof_priv) if
> (ieee->pHTInfo == NULL) {
>  		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc
> memory for HTInfo\n");
> -		return NULL;
> +		goto failed;
>  	}
>  	HTUpdateDefaultSetting(ieee);
>  	HTInitializeHTInfo(ieee); //may move to other place.

It looks like the rtl8192e/rtllib_module.c alloc_rtllib has the same
error. They probably where based on the same function.

Cheers,
   Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/