linux-kernel - Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Apr 2012 10:23:34 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Dong Aisheng <aisheng.dong@...escale.com>
Cc:	Shawn Guo <shawn.guo@...aro.org>,
	Dong Aisheng <dongas86@...il.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	linus.walleij@...ricsson.com, devicetree-discuss@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org, rob.herring@...xeda.com,
	kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver

On Mon, Apr 16, 2012 at 5:35 AM, Dong Aisheng
<aisheng.dong@...escale.com> wrote:
> On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote:
>> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote:
>> ...
>> > For MX3 and MX5, before their pinctrl driver are available, user may
>> > need to define a dummy in dt to avoid such an error.
>> >
>> That is insane, and will not work.
>>
>> 1) We do not have device tree support for MX3 yet.
>> 2) It's not practical to add dummy entries in dt to avoid the error.
>> 3) There are still so many non-dt board files support in the tree.
>> How will they work with that?
>>
>> My suggestion is to not make it an error but a dev_dbg, assuming that
>> the pins are already set up by platform code if we do not find the
>> entry from pinctrl system.  We can take it as a transition solution,
>> and turn the dev_dbg back to error when all the users of the device
>> driver are converted to device tree.
>>
> My thinking is let pinctrl core handle dummy state as regulator subsystem
> and does not depend on dt.
> Linus, Stephen, any comment?

I think this was discussed in another thread and Sascha agreed that
wee need dummy pinctrl to copy with a smooth transition in i.MX.

So I'm happy with that, we just need to finalize a patch, poke
me if I missed some patch...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/