linux-kernel - Re: [PATCH 2/4] ftrace: Remove unused ftrace_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Apr 2012 07:26:16 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ftrace: Remove unused ftrace_update_time
 variable/code

On Wed, 2012-04-25 at 10:23 +0200, Jiri Olsa wrote:
> The update time of the records update is meassured but never
> used. It was probably dropped along the way, removing it.

No it's not dropped. I have patches that read it. But you are correct,
that I should either add those patches, or moved this code out into
those patches, and keep the kernel clean.

Actually, as there's a debug file in the debugfs code now
(dyn_ftrace_total_info). That would be a good place to put this info.

-- Steve

> 
> Also changing ftrace_update_cnt static variable into automatic,
> since it's used only in ftrace_update_code function.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/