lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 25 Apr 2012 10:58:38 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Axel Lin <axel.lin@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Samuel Ortiz <sameo@...ux.intel.com>
Subject: RE: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c
 fails

Thanks for the patch.
Acked by: Venu Byravarasu<vbyravarasu@...dia.com>

> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@...il.com]
> Sent: Wednesday, April 25, 2012 7:01 AM
> To: linux-kernel@...r.kernel.org
> Cc: Samuel Ortiz; Venu Byravarasu
> Subject: [PATCH] mfd: tps65090: Return proper error if regmap_init_i2c fails
> 
> Return proper error instead of 0 if regmap_init_i2c fails.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/tps65090.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
> index 47f802b..da821d9 100644
> --- a/drivers/mfd/tps65090.c
> +++ b/drivers/mfd/tps65090.c
> @@ -286,10 +286,10 @@ static int __devinit tps65090_i2c_probe(struct
> i2c_client *client,
>  	tps65090->rmap = regmap_init_i2c(tps65090->client,
>  		&tps65090_regmap_config);
>  	if (IS_ERR(tps65090->rmap)) {
> -		dev_err(&client->dev, "regmap_init failed with err: %ld\n",
> -			PTR_ERR(tps65090->rmap));
> +		ret = PTR_ERR(tps65090->rmap);
> +		dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
>  		goto err_irq_exit;
> -	};
> +	}
> 
>  	ret = mfd_add_devices(tps65090->dev, -1, tps65090s,
>  		ARRAY_SIZE(tps65090s), NULL, 0);
> --
> 1.7.5.4
> 
> 

Powered by blists - more mailing lists