linux-kernel - RE: [PATCH] media: videobuf2-dma-contig: quiet sparse noise about plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 Apr 2012 16:08:09 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'H Hartley Sweeten' <hartleys@...ionengravers.com>,
	'Linux Kernel' <linux-kernel@...r.kernel.org>
Cc:	linux-media@...r.kernel.org, pawel@...iak.com,
	kyungmin.park@...sung.com, mchehab@...radead.org
Subject: RE: [PATCH] media: videobuf2-dma-contig: quiet sparse noise about
 plain integer as NULL pointer

Hi,

On Wednesday, April 25, 2012 1:13 AM H Hartley Sweeten wrote:
 
> The function vb2_dma_contig_vaddr returns a void * not an integer.
> 
> Quiets the sparse noise:
> 
> warning: Using plain integer as NULL pointer
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Pawel Osciak <pawel@...iak.com>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Cc: Kyungmin Park <kyungmin.park@...sung.com>
> Cc: Mauro Carvalho Chehab <mchehab@...radead.org>

Acked-by: Marek Szyprowski <m.szyprowski@...sung.com>

> ---
> 
> diff --git a/drivers/media/video/videobuf2-dma-contig.c b/drivers/media/video/videobuf2-dma-
> contig.c
> index f17ad98..7de6843 100644
> --- a/drivers/media/video/videobuf2-dma-contig.c
> +++ b/drivers/media/video/videobuf2-dma-contig.c
> @@ -85,7 +85,7 @@ static void *vb2_dma_contig_vaddr(void *buf_priv)
>  {
>  	struct vb2_dc_buf *buf = buf_priv;
>  	if (!buf)
> -		return 0;
> +		return NULL;
> 
>  	return buf->vaddr;
>  }

Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/