linux-kernel - Re: [PATCH] NFSv4: Add modalias for "nfs4"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2012 15:21:15 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	Josh Boyer <jwboyer@...hat.com>
CC:	Jim Rees <rees@...ch.edu>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] NFSv4: Add modalias for "nfs4"

On Fri, 2012-04-27 at 11:14 -0400, Josh Boyer wrote:
> On Fri, Apr 27, 2012 at 03:02:07PM +0000, Myklebust, Trond wrote:
> > On Fri, 2012-04-27 at 10:53 -0400, Josh Boyer wrote:
> > > On Fri, Apr 27, 2012 at 02:50:28PM +0000, Myklebust, Trond wrote:
> > > > On Fri, 2012-04-27 at 10:48 -0400, Josh Boyer wrote:
> > > > > On Fri, Apr 27, 2012 at 10:19:18AM -0400, Jim Rees wrote:
> > > > > > Josh Boyer wrote:
> > > > > > 
> > > > > >   When NFSv4 is configured, the support goes into the nfs.ko module.
> > > > > >   However, nfs-utils seems to pass "nfs4" as the fileststem type for
> > > > > >   NFSv4 mounts.
> > > > > > 
> > > > > > Weren't we going to change that to nfs and use nfsvers to select nfs4?
> > > > > 
> > > > > I have, approximately, no idea.  At least the version of nfs-utils found
> > > > > in Fedora 17 and rawhide, it's still using "nfs4".   I believe that is
> > > > > nfs-utils-1.2.6-rc6 based.
> > > > 
> > > > nfs4 is still _supported_ in Fedora 17, rawhide and upstream as a legacy
> > > > feature, but the recommended practice should be to mount -t nfs -overs=4
> > > > (or -overs=4.1).
> > > 
> > > OK.  So either this patch needs to go in, or something needs to add:
> > > 
> > > alias nfs4 nfs
> > > 
> > > to a conf file so modprobe picks it up.  I figured the kernel could add
> > > the alias itself.  Is there a reason not to?
> > 
> > Yes. This is a legacy feature that we want to encourage people to move
> > their systems off...
> 
> So essentially what needs to happen is:
> 
> - Recent distros still ship the modalias in a conf file
> - Upstream nfs-utils starts translating 'mount -t nfs4' into 'mount -t
>   nfs -overs=4' in /sbin/mount.nfs4
> - Upstream releases that
> - Distros drop the alias.
> 
> Right?

No. Really all we need to do is add a printf() to /sbin/mount.nfs4 to
the effect that this is a legacy feature and that '-t nfs -overs=4' is
the recommended mount option. Perhaps the distros can also have their
distro upgrade utilities edit /etc/fstab to upgrade those automatically.

Then the distros can drop the alias whenever they think it is
appropriate.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com