linux-kernel - Re: [PATCH] clk: constify parent name arrays in macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Apr 2012 21:18:36 +0300
From:	Felipe Balbi <balbi@...com>
To:	"Turquette, Mike" <mturquette@...com>
Cc:	Rajendra Nayak <rnayak@...com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: constify parent name arrays in macros

On Fri, Apr 27, 2012 at 10:55:50AM -0700, Turquette, Mike wrote:
> On Fri, Apr 27, 2012 at 5:28 AM, Rajendra Nayak <rnayak@...com> wrote:
> > parent name array is now expected to be const char *, make
> > the relevent changes in the clk macros which define
> > default clock types.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@...com>
> 
> Good catch Rajendra.  I'll pull it into clk-next.
> 
> Regards,
> Mike
> 
> > ---
> >  include/linux/clk-private.h |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/clk-private.h b/include/linux/clk-private.h
> > index eeae7a3..6ebec83 100644
> > --- a/include/linux/clk-private.h
> > +++ b/include/linux/clk-private.h
> > @@ -70,7 +70,7 @@ struct clk {
> >  #define DEFINE_CLK_FIXED_RATE(_name, _flags, _rate,            \
> >                                _fixed_rate_flags)              \
> >        static struct clk _name;                                \
> > -       static char *_name##_parent_names[] = {};               \
> > +       static const char *_name##_parent_names[] = {};         \

does it make sense to have this as:

static const char * const _name##_parent_names[] = { }; ??

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)