| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 May 2012 23:40:33 +0200 From: Peter Hüwe <PeterHuewe@....de> To: Florian Tobias Schandinat <FlorianSchandinat@....de> Cc: Thomas Winischhofer <thomas@...ischhofer.net>, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] video/sis: Use SiS_DRAMType from init.h and annotate it __devinitconst Hi Florian, > As far as I can see it should be possible to keep the array in > sis_main.c and just delete it in the header files, shouldn't it? I'd > prefer to do it this way. Yes it is absolutely possible to leave it in sis_main.c and remove it from the header files. I already thought about this when creating the patch, but decided against it, as the 17*5 = 85 bytes are allocated on the stack, while they nicely can be put in the .devinit.rodata section ;) With the patch: 344072 sis_main.o 1200950 sisfb.o 1217491 sisfb.ko vs without the patch and removing it only from the header: 344176 sis_main.o 1201056 sisfb.o 1217597 sisfb.ko -> ~100bytes more in the final module. However I'm fine with this and will remove it from the header and squash this together with the "video/sis: Remove unused structs SiS_SDRDRAM_TYPE/SiS_DDRDRAM_TYPE" I also sent to you. Thanks, Peterq -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists