linux-kernel - Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 May 2012 15:12:00 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Michael Davidson <md@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct
 show/store functions

On Thu, May 03, 2012 at 03:07:47PM -0700, Michael Davidson wrote:
> [PATCH] driver-core: fix DEVICE_INT_ATTR to use correct show/store functions
> 
> DEVICE_INT_ATTR() should use device_show_int() and device_store_int()
> not device_show_ulong() and device_store_ulong()
> 
> Signed-off-by: Michael Davidson <md@...gle.com>
> ---
> 
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -508,7 +508,7 @@ ssize_t device_store_int(struct device *
>  		{ __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
>  #define DEVICE_INT_ATTR(_name, _mode, _var)  	struct dev_ext_attribute dev_attr_##_name = -		{ __ATTR(_name, _mode, device_show_ulong, device_store_ulong), &(_var) }
> +		{ __ATTR(_name, _mode, device_show_int, device_store_int), &(_var) }

Something odd happened with your patch, and I can't apply it :(

Care to try again?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/