linux-kernel - Re: [PATCH] staging: android: logger: Allocate logs dynamically at boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 May 2012 16:37:07 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tim Bird <tim.bird@...sony.com>
Cc:	Brian Swetland <swetland@...gle.com>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: android: logger: Allocate logs dynamically at
 boot

On Fri, May 04, 2012 at 04:33:16PM -0700, Tim Bird wrote:
> +#define MAX_LOGS	5
> +struct logger_log *logs_array[MAX_LOGS];

You are going to make this a list and not a static array in the
future, right?

> -static int __init init_log(struct logger_log *log)
> +static int __init add_log(struct logger_log *log)
>  {
> -	int ret;
> +	int i;
> 
> +	for (i = 0; i < MAX_LOGS; i++) {
> +		if (logs_array[i] == 0) {
> +			logs_array[i] = log;
> +			return 0;
> +		}
> +	}
> +	return -1;
> +}

I see you didn't run your patch through sparse :(

Care to fix up the sparse warnings and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/