lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 May 2012 18:47:14 -0700 From: Anton Vorontsov <anton.vorontsov@...aro.org> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Oleg Nesterov <oleg@...hat.com>, Russell King <linux@....linux.org.uk>, Mike Frysinger <vapier@...too.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Richard Weinberger <richard@....at>, Paul Mundt <lethal@...ux-sh.org>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, John Stultz <john.stultz@...aro.org>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org, linuxppc-dev@...ts.ozlabs.org, linux-sh@...r.kernel.org, user-mode-linux-devel@...ts.sourceforge.net, linaro-kernel@...ts.linaro.org, patches@...aro.org, linux-mm@...ck.org Subject: Re: [PATCH 1/9] cpu: Introduce clear_tasks_mm_cpumask() helper On Thu, Apr 26, 2012 at 04:59:11PM -0700, Andrew Morton wrote: [...] > > so its not like new tasks will ever get this cpu set in > > + * their mm mask. -- Peter Zijlstra > > + * Thus, we may use rcu_read_lock() here, instead of grabbing > > + * full-fledged tasklist_lock. > > + */ > > + rcu_read_lock(); > > + for_each_process(p) { > > + struct task_struct *t; > > + > > + t = find_lock_task_mm(p); > > + if (!t) > > + continue; > > + cpumask_clear_cpu(cpu, mm_cpumask(t->mm)); > > + task_unlock(t); > > + } > > + rcu_read_unlock(); > > +} > > It is good that this code exists under CONFIG_HOTPLUG_CPU. Did you > check that everything works correctly with CONFIG_HOTPLUG_CPU=n? Yeah, only the code under CONFIG_HOTPLUG_CPU calls the function, so it should be all fine. Thanks! -- Anton Vorontsov Email: cbouatmailru@...il.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists