[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 06 May 2012 00:00:43 +0200
From: Rolf Eike Beer <eike-kernel@...tec.de>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Mikulas Patocka <mpatocka@...hat.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
"James E.J. Bottomley" <jejb@...isc-linux.org>,
Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix compile failure on PA-RISC
Linus Torvalds wrote:
> On Sat, May 5, 2012 at 11:53 AM, Mikulas Patocka <mpatocka@...hat.com>
wrote:
> > What NO_IRQ problem do you mean? There is
> > #define NO_IRQ (-1)
> > in arch/parisc/include/asm/irq.h.
>
> That's the one he means.
>
> Switching it to zero and testing that things still work would be
> appreciated.
>
> Much code already knows that NO_IRQ is supposed to be zero, and
> there's tons of drivers that just do the (correct!) "if (!dev->irq)"
> kind of thing.
>
> Any architecture that has a non-zero NO_IRQ is basically broken.
> Always has been.
The stuff in drivers/parisc/gsc.c doesn't look as if it would survive that
change.
Eike
Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)
Powered by blists - more mailing lists