linux-kernel - Re: [PATCH] max17042_battery: Fix power supply and irq registration ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 May 2012 23:48:47 -0700
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] max17042_battery: Fix power supply and irq registration
 ordering

On Sat, May 05, 2012 at 03:08:37AM +0530, Ramakrishna Pallala wrote:
> IRQ registration should happen only after power supply object usable.
> This patch fixes the ordering of power supply and irq registration
> calls.
> 
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
> ---

Applied, thank you!

And I noticed another small issue: if request_threaded_irq() fails,
we continue with probing (which is OK), but since request failed,
during max17042_remove() and suspend/resume we would call IRQ
routines on a non-requested IRQ.

So, probably you'd want to set client->irq = 0 when request_irq
fails.

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/