linux-kernel - [PATCH] kvm: Enable device LTR/OBFF capibility before doing guest device assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 6 May 2012 23:24:05 +0800
From:	Xudong Hao <xudong.hao@...ux.intel.com>
To:	avi@...hat.com, mtosatti@...hat.com
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	xiantao.zhang@...el.com, xudong.hao@...el.com
Subject: [PATCH] kvm: Enable device LTR/OBFF capibility before doing guest
	device assignment

Enable device LTR/OBFF capibility before do device assignment, so that guest can benefit from them.

Signed-off-by: Xudong Hao <xudong.hao@...el.com>
---
 virt/kvm/iommu.c |   32 ++++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)

diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c
index e9fff98..5139f2d 100644
--- a/virt/kvm/iommu.c
+++ b/virt/kvm/iommu.c
@@ -166,6 +166,10 @@ int kvm_assign_device(struct kvm *kvm,
    if (pdev == NULL)
        return -ENODEV;

+   /* Enable some device capibility before do device assignment,
+    * so that guest can benefit from them.
+    */
+   kvm_iommu_enable_dev_caps(pdev);
    r = iommu_attach_device(domain, &pdev->dev);
    if (r) {
        printk(KERN_ERR "assign device %x:%x:%x.%x failed",
@@ -228,6 +232,7 @@ int kvm_deassign_device(struct kvm *kvm,
        PCI_SLOT(assigned_dev->host_devfn),
        PCI_FUNC(assigned_dev->host_devfn));

+   kvm_iommu_disable_dev_caps(pdev);
    return 0;
 }

@@ -351,3 +356,30 @@ int kvm_iommu_unmap_guest(struct kvm *kvm)
    iommu_domain_free(domain);
    return 0;
 }
+
+static void kvm_iommu_enable_dev_caps(struct pci_dev *pdev)
+{
+   /* set default value */
+   unsigned long type = PCI_EXP_OBFF_SIGNAL_ALWAYS;
+   int snoop_lat_ns = 1024, nosnoop_lat_ns = 1024;
+
+   /* LTR(Latency tolerance reporting) allows devices to send
+    * messages to the root complex indicating their latency
+    * tolerance for snooped & unsnooped memory transactions.
+    */
+   pci_enable_ltr(pdev);
+   pci_set_ltr(pdev, snoop_lat_ns, nosnoop_lat_ns);
+
+   /* OBFF (optimized buffer flush/fill), where supported,
+    * can help improve energy efficiency by giving devices
+    * information about when interrupts and other activity
+    * will have a reduced power impact.
+    */
+   pci_enable_obff(pdev, type);
+}
+
+static void kvm_iommu_disable_dev_caps(struct pci_dev *pdev)
+{
+   pci_disble_obff(pdev);
+   pci_disble_ltr(pdev);
+}
--
1.6.0.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/