linux-kernel - Re: drivers: Probable misuses of ||

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 May 2012 17:34:01 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Guenter Roeck <guenter.roeck@...csson.com>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jarod Wilson <jarod@...hat.com>
Subject: Re: drivers: Probable misuses of ||

On Mon, May 07, 2012 at 09:20:34AM -0700, Joe Perches wrote:
> On Mon, 2012-05-07 at 09:36 +0100, Mark Brown wrote:

> > with no analysis 

> You did elide the "Likely the || should be &&" preface.

By analysis I meant something like "...because X".

> > Compare this with the reports from people like Julia Lawall, for example
> > - they tend to be very clear.  Even simply adding "...as with || they
> > will always be true" would've helped.

> I think it's a pretty basic logic error that most all
> lkml readers should be able to identify most of the time.

"Can spot" and "will spot" are two different things; speaking as someone
on the receiving end of lots of mails it does make a big difference.
Cues in the human written text which show someone thought about the
problem help a lot with catching attention - the more effort it takes to
understand a mail the more likely it is to get skipped, especially if
there's no patch.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)