| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 May 2012 19:56:51 +0300 From: Artem Bityutskiy <dedekind1@...il.com> To: David Woodhouse <dwmw2@...radead.org>, MTD Maling List <linux-mtd@...ts.infradead.org> Cc: Linux Kernel Maling List <linux-kernel@...r.kernel.org> Subject: [PATCH v2 2/4] jffs2: remove unnecessary GC pass on umount From: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com> We do not need to call 'jffs2_write_super()' on unmount. This function causes a GC pass to make sure the current contents is pushed out with the data which we already have on the media. But this is not needed on unmount and only slows unmount down unnecessarily. It is enough to just sync the write-buffer. This call was added by one of the generic VFS rework patch-sets, see 8c85e125124a473d6f3e9bb187b0b84207f81d91. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com> --- fs/jffs2/super.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c index 3422a2d..d3dc9d8 100644 --- a/fs/jffs2/super.c +++ b/fs/jffs2/super.c @@ -316,9 +316,6 @@ static void jffs2_put_super (struct super_block *sb) jffs2_dbg(2, "%s()\n", __func__); - if (sb->s_dirt) - jffs2_write_super(sb); - mutex_lock(&c->alloc_sem); jffs2_flush_wbuf_pad(c); mutex_unlock(&c->alloc_sem); -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists